Mistake in messagebox text

Here you can report bugs found in Far Manager.
Post Reply
drummer
Posts: 2
Joined: Tue 20 Aug, 2013 13:40

Mistake in messagebox text

Post by drummer » Tue 27 Aug, 2013 09:45

Hi,

The screenshot should explain the problem:
Image

Thank You for the best file manager I've ever seen in my life.

User avatar
John Doe
Бюрократ
Posts: 11421
Joined: Wed 27 Apr, 2005 20:42
Has thanked: 17 times
Been thanked: 101 times

Re: Mistake in messagebox text

Post by John Doe » Tue 27 Aug, 2013 10:54

I think message is just incomplete.
Usually you can scroll it back with cursor keys.

drummer
Posts: 2
Joined: Tue 20 Aug, 2013 13:40

Re: Mistake in messagebox text

Post by drummer » Tue 27 Aug, 2013 11:35

How one can know that the message could be scrolled? And even if so - why wouldn't the message box expand automatically to a good size?
It is all about usability...

User avatar
John Doe
Бюрократ
Posts: 11421
Joined: Wed 27 Apr, 2005 20:42
Has thanked: 17 times
Been thanked: 101 times

Re: Mistake in messagebox text

Post by John Doe » Tue 27 Aug, 2013 11:47

You are right.
Please post this wish at bugtracker.

2useven10
Posts: 3045
Joined: Mon 07 Sep, 2009 10:40
Has thanked: 2 times
Been thanked: 84 times

Re: Mistake in messagebox text

Post by 2useven10 » Tue 27 Aug, 2013 15:33

Fails with volume does not contain a recognized file system. please make sure that all required file system drivers are loaded and that the volume is not corrupted.
And yes that is good issue to the bugtracker.

Shmuel
Posts: 5234
Joined: Thu 23 Mar, 2006 21:36
Location: Israel
Has thanked: 16 times
Been thanked: 152 times

Re: Mistake in messagebox text

Post by Shmuel » Tue 27 Aug, 2013 15:51

Fails with volume does not contain a recognized file system. please make sure that all required file system drivers are loaded and that the volume is not corrupted.
2useven10
Try to feed this long line to far.Message - it handles it fine because it does line wrapping.
There is a function LF_Message in LuaFAR (far.Message is based on it), it can be copied to Far with minimal changes.

2useven10
Posts: 3045
Joined: Mon 07 Sep, 2009 10:40
Has thanked: 2 times
Been thanked: 84 times

Re: Mistake in messagebox text

Post by 2useven10 » Tue 27 Aug, 2013 19:29

Actually I am pretty sure that standard far error reporting method already have word wrapping implemented.
Probably there is some special usecase where nonstandard implementation used.

Shmuel
Posts: 5234
Joined: Thu 23 Mar, 2006 21:36
Location: Israel
Has thanked: 16 times
Been thanked: 152 times

Re: Mistake in messagebox text

Post by Shmuel » Tue 27 Aug, 2013 20:55

2useven10 wrote:Actually I am pretty sure that standard far error reporting method already have word wrapping implemented.
Then please tell where it is in Far sources.

2useven10
Posts: 3045
Joined: Mon 07 Sep, 2009 10:40
Has thanked: 2 times
Been thanked: 84 times

Re: Mistake in messagebox text

Post by 2useven10 » Tue 27 Aug, 2013 23:51

message.cpp #343

2useven10
Posts: 3045
Joined: Mon 07 Sep, 2009 10:40
Has thanked: 2 times
Been thanked: 84 times

Re: Mistake in messagebox text

Post by 2useven10 » Wed 28 Aug, 2013 00:12

and there is 'nonstandard implementation' -- panel.cpp #959-993

Shmuel
Posts: 5234
Joined: Thu 23 Mar, 2006 21:36
Location: Israel
Has thanked: 16 times
Been thanked: 152 times

Re: Mistake in messagebox text

Post by Shmuel » Wed 28 Aug, 2013 06:39

2useven10 wrote:message.cpp #343
Have you tested that in practice and seen line wrapping?
Please show a usage example that demonstrates wrapping of long lines.

2useven10
Posts: 3045
Joined: Mon 07 Sep, 2009 10:40
Has thanked: 2 times
Been thanked: 84 times

Re: Mistake in messagebox text

Post by 2useven10 » Wed 28 Aug, 2013 09:19

1) I've fixed somewhat related
2) Help yourself. Any Message(MSG_ERRORTYPE,...) can do that

Shmuel
Posts: 5234
Joined: Thu 23 Mar, 2006 21:36
Location: Israel
Has thanked: 16 times
Been thanked: 152 times

Re: Mistake in messagebox text

Post by Shmuel » Wed 28 Aug, 2013 10:03

2useven10 wrote:1) I've fixed somewhat related
2) Help yourself. Any Message(MSG_ERRORTYPE,...) can do that
1. I don't see any new commits. And even if they were, we were talking about actual state of Far Manager, not about its future state.
2. No, it can't.

User avatar
DrKnS
Posts: 4648
Joined: Thu 04 Aug, 2005 06:44
Location: Kyiv
Has thanked: 4 times
Been thanked: 125 times
Contact:

Re: Mistake in messagebox text

Post by DrKnS » Wed 28 Aug, 2013 10:18

It's not a Message, it's a Dialog.

2useven10
Posts: 3045
Joined: Mon 07 Sep, 2009 10:40
Has thanked: 2 times
Been thanked: 84 times

Re: Mistake in messagebox text

Post by 2useven10 » Wed 28 Aug, 2013 12:09

3621

@DrKnS
sure (it is the reason of 'nonstandard')

@Shmuel
Message(MSG_ERRORTYPE, ...) handles ErrorText wrapping without any changes

Post Reply

Return to “Bug Reports”