Page 1 of 1

Submitting an updated plugin?

Posted: Sat 26 Sep, 2009 11:36
by pepak
I have just modified the standard FTP plugin with two features:

- Modified "overwrite confirmation" dialog to match current FAR's overwrite dialog (Overwrite/Skip/Resume buttons + Remember checkbox, rather than Overwrite/OverwriteAll/Skip/SkipApp/Resume/ResumeAll buttons).
- Added new option "Newer" for overwriting if source file is newer and skipping otherwise. Option works for Download and Upload but not for queue operations.

1) How would I go about submitting the plugin to the repository? I have zero knowledge of using SVN and am not sure I want to install it on my computer, either.

2) Considering that this is a standard plugin and my knowledge of C is very limited, I wouldn't feel quite right about submitting it without a peer review anyway. Who would be the best person to send the plugin to make sure I didn't break something? (The number of changes is quite small so it shouldn't be too much work).

http://www.pepak.net/files/far/farftp-pepak20090926.zip
Archive contains:
- full build for those crazy enough to use it right away
- full sources
- changed source files (for easier diff)

Re: Submitting an updated plugin?

Posted: Sat 26 Sep, 2009 11:54
by DrKnS
See HACKING-EN::Submitting patches

Re: Submitting an updated plugin?

Posted: Sat 26 Sep, 2009 13:35
by pepak
Hmm. Well, I could do the diffs, hopefully (included in the archive above now). I have no idea how to modify the documentation so I will leave that be. The maintainer is t-rex who prefers contact through Mantis (no idea whatsoever how to submit through that!) and Forum, so I'll leave him private message now and hope for the best :-)

Re: Submitting an updated plugin?

Posted: Sat 10 Oct, 2009 10:10
by pepak
Looks like t-rex is dead. I don't know how to use the Mantis. Any other possibility?

Re: Submitting an updated plugin?

Posted: Mon 12 Oct, 2009 12:17
by HaRT
pepak wrote:Looks like t-rex is dead. I don't know how to use the Mantis. Any other possibility?
I hope he is alive. :)
Have you seen the “Mantis” link at the top of this page?

Re: Submitting an updated plugin?

Posted: Mon 12 Oct, 2009 13:03
by pepak
I have found the Mantis, but I have no idea how to use it.

Re: Submitting an updated plugin?

Posted: Mon 12 Oct, 2009 13:23
by HaRT
pepak wrote:I have found the Mantis, but I have no idea how to use it.
Well, Mantis is a good enough issue tracking system with extensive documentation.
In short, you need to register there (it's free ;-) ) and then report an issue. Please fill all relevant issue fields and attach your patch as a file.
Please believe me, the process is very simple and straightforward.

Re: Submitting an updated plugin?

Posted: Wed 14 Oct, 2009 11:39
by pepak
Well, it's posted. I hope I did it correctly and it will get merged into the official plugin sometime soon.

Re: Submitting an updated plugin?

Posted: Thu 22 Oct, 2009 17:22
by pepak
Doesn't seem to have much effect :-((

Re: Submitting an updated plugin?

Posted: Thu 22 Oct, 2009 23:37
by Px
pepak wrote:Doesn't seem to have much effect :-((
Lack of free time, I think, reading Mantis I saw that some patches were not added to main svn for month because of that reason. Try to bump ticket in week or two :)