Page 3 of 3

Fast Find Enhanced

Posted: Mon 17 Dec, 2018 12:36
by saiberpink

Latest post of the previous page:

Shmuel wrote:
Mon 17 Dec, 2018 11:27
In the plugin's file ffind.lua, find 2 occurences of FST_DATA and replace them with "FST_DATA".
Then reload Far.
works. thank you!

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 11:55
by hayabusa2
Помогите решить ошибку

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 12:03
by Shmuel

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 12:14
by Shmuel
Надо бы поместить на плагринг версию с фиксами для предотвращения в будущем подобных вопросов. Может админы как-то это сделают (свой вариант версии предоставлю). Автор уже несколько лет не появляется.

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 13:29
by John Doe
Выложите тут, на плагринге добавим.

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 13:40
by DrKnS
Shmuel, I've just added you to its authors so you should be able to upload a new version.

P.S. Would you mind fixing the issue from the previous page as well?

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 14:31
by Shmuel
DrKnS, thank you, it has been uploaded.

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 14:35
by Shmuel
DrKnS wrote:
Sun 01 Sep, 2019 13:40
P.S. Would you mind fixing the issue from the previous page as well?
I didn't read it in details, is it Windows 10 related? (I don't yet have that OS).

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 14:46
by DrKnS
Shmuel wrote:
Sun 01 Sep, 2019 14:35
is it Windows 10 related?
Not really, just an incorrect API usage.

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 15:51
by Shmuel
DrKnS, I'm trying to reproduce the bug according to description of how to do that but I fail to see any problem. Here are my settings:

Code: Select all

[x] Use Virtual Terminal for rendering
[x] ClearType-friendly redraw (can be slow)

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 16:48
by DrKnS
Shmuel wrote:
Sun 01 Sep, 2019 15:51
I fail to see any problem
I thought the linked post explains it quite clearly - the foreground colour of the numbers next to the arrows is supposed to be COL_DIALOGLISTSELECTEDHIGHLIGHT, but because of the bug it's always something else - green or whatever.
Obviously you won't see anything similar to those screenshots because a workaround was added to Far long time ago.

Something like this:
  1. --- ffind.lua   Mon Dec 17 10:33:58 2018
  2. +++ ffind.lua   Sun Sep  1 16:45:46 2019
  3. @@ -655,8 +655,7 @@
  4.      end
  5.  
  6.      if (msg == _F.DN_CTLCOLORDLGITEM) then
  7. -        if (param1==3) then param2[1].ForegroundColor = far.Colors.COL_DIALOGLISTSELECTEDHIGHLIGHT; return param2; end
  8. -        if (param1==4) then param2[1].ForegroundColor = far.Colors.COL_DIALOGLISTSELECTEDHIGHLIGHT; return param2; end
  9. +        if (param1==3 or param1==4) then param2[1].ForegroundColor = far.AdvControl("ACTL_GETARRAYCOLOR")[far.Colors.COL_DIALOGLISTSELECTEDHIGHLIGHT].ForegroundColor; return param2; end
  10.      elseif (msg == _F.DN_CONTROLINPUT) then
  11.          if (param1 == 2) then
  12.              if ((param2.EventType ~= _F.KEY_EVENT) and (param2.EventType ~= _F.FARMACRO_KEY_EVENT)) then

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 17:16
by Shmuel
OK, I've applied your patch and that color has changed from green to bright yellow.
I understand that was a bug, but now my problem is that the green color (that was due to the bug) looks much better for me than that bright yellow one. I really don't know what to do :)

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 17:40
by DrKnS
Well, I have no idea whether the author wanted yellow (and didn't notice that it was green), green (and bruteforced it) or didn't care at all.
The default palette doesn't have green anywhere, so if you prefer to keep it it's better to just set it explicitly to 0x2.

Fast Find Enhanced

Posted: Sun 01 Sep, 2019 18:39
by Shmuel
After some playing with the colors COL_DIALOGBOXTITLE (default=black) has been selected.
The original value (COL_DIALOGLISTSELECTEDHIGHLIGHT) was left as a comment (in case someone would want it).
Uploaded the new version.