Here you can discuss about your favorite plug-in.
-
saiberpink
- Posts: 13
- Joined: Mon 13 Aug, 2018 10:17
- Has thanked: 4 times
Post
by saiberpink » Mon 17 Dec, 2018 12:36
Latest post of the previous page:
Shmuel wrote: ↑Mon 17 Dec, 2018 11:27
In the plugin's file ffind.lua, find 2 occurences of FST_DATA and replace them with "FST_DATA".
Then reload Far.
works. thank you!
saiberpink
-
Shmuel
- Posts: 5919
- Joined: Thu 23 Mar, 2006 21:36
- Location: Israel
- Has thanked: 23 times
- Been thanked: 233 times
Post
by Shmuel » Sun 01 Sep, 2019 12:03
Last edited by
Shmuel on Sun 01 Sep, 2019 12:13, edited 2 times in total.
Shmuel
-
Shmuel
- Posts: 5919
- Joined: Thu 23 Mar, 2006 21:36
- Location: Israel
- Has thanked: 23 times
- Been thanked: 233 times
Post
by Shmuel » Sun 01 Sep, 2019 12:14
Надо бы поместить на плагринг версию с фиксами для предотвращения в будущем подобных вопросов. Может админы как-то это сделают (свой вариант версии предоставлю). Автор уже несколько лет не появляется.
Shmuel
-
DrKnS
- Posts: 5426
- Joined: Thu 04 Aug, 2005 06:44
- Location: Kyiv
- Has thanked: 6 times
- Been thanked: 250 times
Post
by DrKnS » Sun 01 Sep, 2019 13:40
Shmuel, I've just added you to its authors so you should be able to upload a new version.
P.S. Would you mind fixing the issue from the previous page as well?
DrKnS
-
Shmuel
- Posts: 5919
- Joined: Thu 23 Mar, 2006 21:36
- Location: Israel
- Has thanked: 23 times
- Been thanked: 233 times
Post
by Shmuel » Sun 01 Sep, 2019 14:31
DrKnS, thank you, it has been uploaded.
Shmuel
-
Shmuel
- Posts: 5919
- Joined: Thu 23 Mar, 2006 21:36
- Location: Israel
- Has thanked: 23 times
- Been thanked: 233 times
Post
by Shmuel » Sun 01 Sep, 2019 14:35
DrKnS wrote: ↑Sun 01 Sep, 2019 13:40
P.S. Would you mind fixing the issue from the previous page as well?
I didn't read it in details, is it Windows 10 related? (I don't yet have that OS).
Shmuel
-
Shmuel
- Posts: 5919
- Joined: Thu 23 Mar, 2006 21:36
- Location: Israel
- Has thanked: 23 times
- Been thanked: 233 times
Post
by Shmuel » Sun 01 Sep, 2019 15:51
DrKnS, I'm trying to reproduce the bug according to description of how to do that but I fail to see any problem. Here are my settings:
Code: Select all
[x] Use Virtual Terminal for rendering
[x] ClearType-friendly redraw (can be slow)
Shmuel
-
DrKnS
- Posts: 5426
- Joined: Thu 04 Aug, 2005 06:44
- Location: Kyiv
- Has thanked: 6 times
- Been thanked: 250 times
Post
by DrKnS » Sun 01 Sep, 2019 16:48
Shmuel wrote: ↑Sun 01 Sep, 2019 15:51
I fail to see any problem
I thought the linked post explains it quite clearly - the foreground colour of the numbers next to the arrows is supposed to be COL_DIALOGLISTSELECTEDHIGHLIGHT, but because of the bug it's always something else - green or whatever.
Obviously you won't see anything similar to those screenshots because a workaround was added to Far long time ago.
Something like this:
--- ffind.lua Mon Dec 17 10:33:58 2018
+++ ffind.lua Sun Sep 1 16:45:46 2019
@@ -655,8 +655,7 @@
end
if (msg == _F.DN_CTLCOLORDLGITEM) then
- if (param1==3) then param2[1].ForegroundColor = far.Colors.COL_DIALOGLISTSELECTEDHIGHLIGHT; return param2; end
- if (param1==4) then param2[1].ForegroundColor = far.Colors.COL_DIALOGLISTSELECTEDHIGHLIGHT; return param2; end
+ if (param1==3 or param1==4) then param2[1].ForegroundColor = far.AdvControl("ACTL_GETARRAYCOLOR")[far.Colors.COL_DIALOGLISTSELECTEDHIGHLIGHT].ForegroundColor; return param2; end
elseif (msg == _F.DN_CONTROLINPUT) then
if (param1 == 2) then
if ((param2.EventType ~= _F.KEY_EVENT) and (param2.EventType ~= _F.FARMACRO_KEY_EVENT)) then
DrKnS
-
Shmuel
- Posts: 5919
- Joined: Thu 23 Mar, 2006 21:36
- Location: Israel
- Has thanked: 23 times
- Been thanked: 233 times
Post
by Shmuel » Sun 01 Sep, 2019 17:16
OK, I've applied your patch and that color has changed from green to bright yellow.
I understand that was a bug, but now my problem is that the green color (that was due to the bug) looks much better for me than that bright yellow one. I really don't know what to do

Shmuel
-
DrKnS
- Posts: 5426
- Joined: Thu 04 Aug, 2005 06:44
- Location: Kyiv
- Has thanked: 6 times
- Been thanked: 250 times
Post
by DrKnS » Sun 01 Sep, 2019 17:40
Well, I have no idea whether the author wanted yellow (and didn't notice that it was green), green (and bruteforced it) or didn't care at all.
The default palette doesn't have green anywhere, so if you prefer to keep it it's better to just set it explicitly to 0x2.
DrKnS
-
Shmuel
- Posts: 5919
- Joined: Thu 23 Mar, 2006 21:36
- Location: Israel
- Has thanked: 23 times
- Been thanked: 233 times
Post
by Shmuel » Sun 01 Sep, 2019 18:39
After some playing with the colors COL_DIALOGBOXTITLE (default=black) has been selected.
The original value (COL_DIALOGLISTSELECTEDHIGHLIGHT) was left as a comment (in case someone would want it).
Uploaded the new version.
Shmuel